Yikun removed a comment on pull request #34983:
URL: https://github.com/apache/spark/pull/34983#issuecomment-1019494990
```scala
val builder2 = new ConfigMapBuilder()
.withNewMetadata()
// We don't specify ns2 in here
.withName("configmap2")
.endMetadata()
.addToData("testkey", "testvalue")
.build()
val configMap2 =
// the conf.metadata.namespace is also set to ns2
client.inNamespace("ns2").resource(builder2).createOrReplace()
assert(configMap2.getMetadata.getNamespace === "ns2")
```
I just wanna sure, do we really need this PR?
The case shows even if we don't set namespace in configmap metadata, it will
also set to client namespace which is configured in
[createKubernetesClient](https://github.com/apache/spark/blob/ddc77fb906cb3ce1567d277c2d0850104c89ac25/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/SparkKubernetesClientFactory.scala#L105)
with [conf
namespace](https://github.com/apache/spark/blob/ddc77fb906cb3ce1567d277c2d0850104c89ac25/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterManager.scala#L80).
That is even without this PR, we can also set configmap namespace as
expected(both driver and executor), or did I miss something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
