AngersZhuuuu commented on a change in pull request #34695:
URL: https://github.com/apache/spark/pull/34695#discussion_r791770198
##########
File path: core/src/main/resources/org/apache/spark/ui/static/executorspage.js
##########
@@ -143,23 +143,205 @@ var sumOptionalColumns = [3, 4];
var execOptionalColumns = [5, 6, 7, 8, 9, 10, 13, 14, 25];
var execDataTable;
var sumDataTable;
+var executorSummaryMetricsTableArray = [];
+var executorSummaryMetricsTableCurrentStateArray = [];
+var executorSummaryMetricsDataTable;
function reselectCheckboxesBasedOnTaskTableState() {
var allChecked = true;
+ var executorSummaryMetricsTableCurrentFilteredArray =
executorSummaryMetricsTableCurrentStateArray.slice();
if (typeof execDataTable !== "undefined") {
for (var k = 0; k < execOptionalColumns.length; k++) {
if (execDataTable.column(execOptionalColumns[k]).visible()) {
$("[data-exec-col-idx=" + execOptionalColumns[k] +
"]").prop("checked", true);
+ var executorSumCheckBoxId = $("[data-exec-col-idx=" +
execOptionalColumns[k] + "]").attr('exec-sum-idx');
+ var selectedExecutorSummaryMetrics =
executorSummaryMetricsTableArray.filter(row =>
(row.executorSumCheckBoxId).toString() == executorSumCheckBoxId)
+ for(var value in selectedExecutorSummaryMetrics) {
+
executorSummaryMetricsTableCurrentStateArray.push(selectedExecutorSummaryMetrics[value]);
+ }
+ executorSummaryMetricsTableCurrentFilteredArray =
executorSummaryMetricsTableCurrentStateArray.slice();
} else {
allChecked = false;
}
}
}
+
+
createDataTableForExecutorSummaryMetricsTable(executorSummaryMetricsTableCurrentFilteredArray)
+
if (allChecked) {
$("#select-all-box").prop("checked", true);
}
}
+function getColumnNameForExecutorMetricSummary(columnKey) {
+ switch(columnKey) {
Review comment:
> Shall we use a string map instead of switch?
Hmm, same method from stagingspage.js
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
