dongjoon-hyun commented on a change in pull request #35300: URL: https://github.com/apache/spark/pull/35300#discussion_r791031749
########## File path: resource-managers/kubernetes/integration-tests/dev/spark-rbac.yaml ########## @@ -26,7 +26,9 @@ metadata: name: spark-sa namespace: spark --- -apiVersion: rbac.authorization.k8s.io/v1beta1 +# Note: change `v1` to `v1beta1` when Kubernetes version < v1.8 +# https://kubernetes.io/docs/reference/using-api/deprecation-guide/#rbac-resources-v122 Review comment: Please remove this note. ########## File path: resource-managers/kubernetes/integration-tests/dev/spark-rbac.yaml ########## @@ -38,7 +40,9 @@ rules: verbs: - "*" --- -apiVersion: rbac.authorization.k8s.io/v1beta1 +# Note: change `v1` to `v1beta1` when Kubernetes version < v1.8 +# https://kubernetes.io/docs/reference/using-api/deprecation-guide/#rbac-resources-v122 Review comment: ditto. ########## File path: resource-managers/kubernetes/integration-tests/dev/spark-rbac.yaml ########## @@ -49,4 +53,4 @@ subjects: roleRef: kind: ClusterRole name: spark-role - apiGroup: rbac.authorization.k8s.io \ No newline at end of file + apiGroup: rbac.authorization.k8s.io Review comment: I agree with you. The change is okay. Just a note: This is what your editor does although you aren't aware of it manually. If you do this in the opposite direction, it would get a negative feedback. > I didn't change anything in here manually. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
