venkata91 commented on a change in pull request #34122:
URL: https://github.com/apache/spark/pull/34122#discussion_r792275865
##########
File path: core/src/main/scala/org/apache/spark/Dependency.scala
##########
@@ -144,12 +144,16 @@ class ShuffleDependency[K: ClassTag, V: ClassTag, C:
ClassTag](
_shuffleMergedFinalized = true
}
+ def shuffleMergeFinalized: Boolean = {
Review comment:
Yes, that is correct.
As you mentioned above,
- retry for an INDETERMINATE shuffle - `newShuffleMergeState` will set
`_shuffleMergedFinalized` to false.
- retry for a DETERMINATE shuffle
- `mergerLocs.nonEmpty` (merge enabled) -> `_shuffleMergeFinalized` would
be `true` -> `shuffleMergeAllowed` -> false for retry/reuse cases.
- `mergerLocs.isEmpty` (merge disabled) -> `_shuffleMergeFinalized` would
be `false` -> `shuffleMergeAllowed` -> `true` for retry/reuse cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
