MaxGekk commented on a change in pull request #35302:
URL: https://github.com/apache/spark/pull/35302#discussion_r792522671
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala
##########
@@ -93,8 +93,8 @@ object QueryCompilationErrors {
def unsupportedIfNotExistsError(tableName: String): Throwable = {
Review comment:
`InsertIntoSQLOnlyTests` has a test for the error already. BTW, the test
from `InsertIntoSQLOnlyTests` runs as part of:
- V1WriteFallbackSessionCatalogSuite
- DataSourceV2SQLSuite
- DataSourceV2SQLSessionCatalogSuite
- DataSourceV2DataFrameSuite
- DataSourceV2DataFrameSessionCatalogSuite
@cloud-fan How about to create the `QueryCompilationErrorsSuiteBase`
trait/abstract class and include it to those test suites?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
