HeartSaVioR commented on a change in pull request #35343:
URL: https://github.com/apache/spark/pull/35343#discussion_r794141812
##########
File path: core/src/main/scala/org/apache/spark/util/Clock.scala
##########
@@ -99,3 +101,29 @@ private[spark] class SystemClock extends Clock {
-1
}
}
+
+/**
Review comment:
I meant, we can leverage ManualClock on implementing MockedSystemClock
singleton instance. ManualClock contains all the functionality we need in new
mechanism of timing, right?
If it is due to the package private, I think it's OK to make it public, with
probably pinging some folks in core side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
