Yikun commented on a change in pull request #34924:
URL: https://github.com/apache/spark/pull/34924#discussion_r794185445
##########
File path:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesUtils.scala
##########
@@ -381,4 +382,32 @@ object KubernetesUtils extends Logging {
}
}
}
+
+ @Since("3.3.0")
+ def loadFeatureStep(conf: KubernetesConf, className: String):
KubernetesFeatureConfigStep = {
+ val constructors = Utils.classForName(className).getConstructors
Review comment:
Thanks for your suggestion.
> avoid reflections here and my idea is the following
Yes, it's a little bit complex and some hack taste, but the advantage would
be same experience and interface with native feature step, and init way is
simple, but perhaps bring some different interface for user.
If I understand correctly your idea, this
https://github.com/apache/spark/pull/35345 migth be the alternative way you
mentioend. Could you take a look on it? @attilapiros (I haven't updated the doc
so you could just review on code implementation. )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
