Yikun commented on a change in pull request #35345: URL: https://github.com/apache/spark/pull/35345#discussion_r794181824
########## File path: resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/PodBuilderSuite.scala ########## @@ -249,3 +283,57 @@ class TestStepTwo extends KubernetesFeatureConfigStep { SparkPod(podWithLocalDirVolumes, containerWithLocalDirVolumeMounts) } } + +/** + * A test user feature step. + */ +class TestStepWithConf extends KubernetesFeatureConfigStep { + import io.fabric8.kubernetes.api.model._ + + private var kubernetesConf: KubernetesConf = _ + + override def init(conf: KubernetesConf): Unit = { + kubernetesConf = conf + } Review comment: If user want to use `KubernetesConf` rather than driver or executor conf, they need to reimplements `KubernetesFeatureConfigStep.init` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org