cloud-fan commented on a change in pull request #35328: URL: https://github.com/apache/spark/pull/35328#discussion_r794319274
########## File path: sql/core/src/test/scala/org/apache/spark/sql/errors/QueryParsingErrorsSuite.scala ########## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.errors + +import org.apache.spark.sql.QueryTest +import org.apache.spark.sql.catalyst.parser.ParseException +import org.apache.spark.sql.test.SharedSparkSession + +class QueryParsingErrorsSuite extends QueryTest with SharedSparkSession { + def validateParsingError( + sqlText: String, + errorClass: String, + sqlState: String, + message: String): Unit = { + val e = intercept[ParseException] { + sql(sqlText) + } + assert(e.getErrorClass === errorClass) + assert(e.getSqlState === sqlState) + assert(e.getMessage.contains(message)) + } + + test("UNSUPPORTED_FEATURE: LATERAL join with NATURAL join not supported") { + validateParsingError( + sqlText = "SELECT * FROM t1 NATURAL JOIN LATERAL (SELECT c1 + c2 AS c2)", + errorClass = "UNSUPPORTED_FEATURE", + sqlState = "0A000", + message = "The feature is not supported: LATERAL join with NATURAL join.") + } + + test("UNSUPPORTED_FEATURE: LATERAL join with USING join not supported") { + validateParsingError( + sqlText = "SELECT * FROM t1 JOIN LATERAL (SELECT c1 + c2 AS c2) USING (c2)", + errorClass = "UNSUPPORTED_FEATURE", + sqlState = "0A000", + message = "The feature is not supported: LATERAL join with USING join.") + } + + test("UNSUPPORTED_FEATURE: Unsupported LATERAL join type") { + Seq(("RIGHT OUTER", "RightOuter"), + ("FULL OUTER", "FullOuter"), + ("LEFT SEMI", "LeftSemi"), + ("LEFT ANTI", "LeftAnti")).foreach { pair => + validateParsingError( + sqlText = s"SELECT * FROM t1 ${pair._1} JOIN LATERAL (SELECT c1 + c2 AS c3) ON c2 = c3", + errorClass = "UNSUPPORTED_FEATURE", + sqlState = "0A000", + message = s"The feature is not supported: LATERAL join type '${pair._2}'.") + } + } + + test("SPARK-35789: INVALID_LATERAL_JOIN_RELATION - LATERAL can only be used with subquery") { Review comment: I can't really tell if it's an unsupported feature or invalid syntax. Probably the latter as `SELECT * FROM t1, LATERAL (LATERAL t2)` looks really like a bad SQL. How about we add a new error class `INVALID_SQL_SYNTAX` for this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
