allisonwang-db commented on a change in pull request #35352:
URL: https://github.com/apache/spark/pull/35352#discussion_r794884653
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
##########
@@ -2795,3 +2795,46 @@ case class Sentences(
copy(str = newFirst, language = newSecond, country = newThird)
}
+
+case class SplitByDelimiter(
+ str: Expression,
Review comment:
nit: 4 space indentation
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
##########
@@ -2795,3 +2795,46 @@ case class Sentences(
copy(str = newFirst, language = newSecond, country = newThird)
}
+
+case class SplitByDelimiter(
+ str: Expression,
+ delimiter: Expression) extends BinaryExpression with ImplicitCastInputTypes
with NullIntolerant {
+ override def dataType: DataType = ArrayType(StringType, containsNull = false)
+ override def inputTypes: Seq[DataType] = Seq(StringType, StringType)
+ override def left: Expression = str
+ override def right: Expression = delimiter
+
+ override def nullSafeEval(string: Any, delimiter: Any): Any = {
+ val strings = string.asInstanceOf[UTF8String].split(
+ delimiter.asInstanceOf[UTF8String], -1, true)
+ new GenericArrayData(strings.asInstanceOf[Array[Any]])
+ }
+
+ override def doGenCode(ctx: CodegenContext, ev: ExprCode): ExprCode = {
+ val arrayClass = classOf[GenericArrayData].getName
+ nullSafeCodeGen(ctx, ev, (str, delimiter) => {
+ // Array in java is covariant, so we don't need to cast UTF8String[] to
Object[].
+ s"""${ev.value} = new $arrayClass($str.split($delimiter,-1,
true));""".stripMargin
+ })
+ }
+
+ override protected def withNewChildrenInternal(
+ newFirst: Expression, newSecond: Expression): SplitByDelimiter =
+ copy(str = newFirst, delimiter = newSecond)
+}
+
+case class SplitPart (
+ str: Expression,
Review comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
