mridulm commented on a change in pull request #34122:
URL: https://github.com/apache/spark/pull/34122#discussion_r796060753
##########
File path:
core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala
##########
@@ -3613,8 +3613,8 @@ class DAGSchedulerSuite extends SparkFunSuite with
TempLocalSparkContext with Ti
val shuffleStage2 =
scheduler.stageIdToStage(1).asInstanceOf[ShuffleMapStage]
assert(shuffleStage2.shuffleDep.getMergerLocs.nonEmpty)
- assert(shuffleStage2.shuffleDep.shuffleMergeFinalized)
- assert(shuffleStage1.shuffleDep.shuffleMergeFinalized)
+ assert(shuffleStage2.shuffleDep.isShuffleMergeFinalizedMarked)
+ assert(shuffleStage1.shuffleDep.isShuffleMergeFinalizedMarked)
Review comment:
I am slightly on the fence for some of these test reverts, since we are
doing a stronger check now.
So I am fine with leaving them as-is as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
