parthchandra commented on pull request #35262: URL: https://github.com/apache/spark/pull/35262#issuecomment-1026231119
It is generally a good idea to use off-heap memory if the writable vector is off-heap as copying data between off-heap and on-heap memory is somewhat more expensive. But since it is leading to the memory leak, it is a good idea to remove the off heap usage. I didn't see a difference in performance, so perhaps the effect in this case is not that great. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
