dongjoon-hyun commented on a change in pull request #35373:
URL: https://github.com/apache/spark/pull/35373#discussion_r796146992
##########
File path:
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorRollPluginSuite.scala
##########
@@ -172,10 +174,53 @@ class ExecutorRollPluginSuite extends SparkFunSuite with
PrivateMethodTester {
plugin.invokePrivate(_choose(list, ExecutorRollPolicy.AVERAGE_DURATION)))
}
- test("Policy: OUTLIER - Work like TOTAL_DURATION if there is no outlier") {
+ test("Policy: OUTLIER_OR_TOTAL_DURATION - Use TOTAL_DURATION if there is no
outlier") {
assertEquals(
plugin.invokePrivate(_choose(list, ExecutorRollPolicy.TOTAL_DURATION)),
- plugin.invokePrivate(_choose(list, ExecutorRollPolicy.OUTLIER)))
+ plugin.invokePrivate(_choose(list,
ExecutorRollPolicy.OUTLIER_OR_TOTAL_DURATION)))
+ }
+
+ test("Policy: OUTLIER_OR_TOTAL_DURATION - Detect an average task duration
outlier") {
Review comment:
Actually, this is orthogonal to your proposal. We usually put one theme
in a PR and avoid mixing different things.
Could you make a separate PR for adding more test coverage for
`OUTLIER_OR_TOTAL_DURATION`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
