thesamet commented on a change in pull request #35378:
URL: https://github.com/apache/spark/pull/35378#discussion_r796323428
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
##########
@@ -371,6 +384,18 @@ case class Invoke(
}
private lazy val encodedFunctionName =
ScalaReflection.encodeFieldNameToIdentifier(functionName)
+ private var isDeterministic: Boolean = true
Review comment:
Note that having a `var` here breaks the convention that case classes
are immutable, and also breaks `copy` and equality checks which would ignore
this value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
