entong commented on a change in pull request #35352:
URL: https://github.com/apache/spark/pull/35352#discussion_r797183747
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/StringFunctionsSuite.scala
##########
@@ -657,4 +657,30 @@ class StringFunctionsSuite extends QueryTest with
SharedSparkSession {
}.getMessage
assert(m.contains("data type mismatch: argument 1 requires string type"))
}
+
+ test("SPARK-38063: string split_part function") {
Review comment:
+1
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
##########
@@ -2795,3 +2795,69 @@ case class Sentences(
copy(str = newFirst, language = newSecond, country = newThird)
}
+
+/**
+ * Splits a given string by a specified delimiter.
+ */
+case class SplitByDelimiter(
+ str: Expression,
+ delimiter: Expression)
+ extends BinaryExpression with ImplicitCastInputTypes with NullIntolerant {
+ override def dataType: DataType = ArrayType(StringType, containsNull = false)
+ override def inputTypes: Seq[DataType] = Seq(StringType, StringType)
+ override def left: Expression = str
+ override def right: Expression = delimiter
+
+ override def nullSafeEval(string: Any, delimiter: Any): Any = {
+ val strings = string.asInstanceOf[UTF8String].split(
+ delimiter.asInstanceOf[UTF8String], -1, true)
+ new GenericArrayData(strings.asInstanceOf[Array[Any]])
+ }
+
+ override def doGenCode(ctx: CodegenContext, ev: ExprCode): ExprCode = {
+ val arrayClass = classOf[GenericArrayData].getName
+ nullSafeCodeGen(ctx, ev, (str, delimiter) => {
+ // Array in java is covariant, so we don't need to cast UTF8String[] to
Object[].
+ s"""${ev.value} = new $arrayClass($str.split($delimiter,-1,
true));""".stripMargin
+ })
+ }
+
+ override protected def withNewChildrenInternal(
+ newFirst: Expression, newSecond: Expression): SplitByDelimiter =
+ copy(str = newFirst, delimiter = newSecond)
+}
+
+/**
+ * Splits a given string by a specified delimiter and returns the requested
part.
+ * If any input is null, or index is out of range of split parts, returns null.
+ */
+@ExpressionDescription(
+ usage = """
+ _FUNC_(str, delimiter, partNum) - Splits `str` by delimiter and return
+ requested part of the split (1-based).
Review comment:
Can we mention if negative partNum is supported or not?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
