zero323 commented on pull request #35367: URL: https://github.com/apache/spark/pull/35367#issuecomment-1028873667
Thanks for the review @HyukjinKwon! I am still working on this one (there was an issue with some of the `Generic` positions, that caused MRO failures) and won't make it final until I have time to finalize `ml.wrapper` ‒ because we have crazy inheritance hierarchies with a lot of abstract things, making small changes tends to escalate all over the place (`ml.wrapper`, which is not big by itself, might require changes in stubs for all `ml` modules 😰, because of the abstract `_things` exposed to type checkers) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
