HeartSaVioR commented on pull request #35362: URL: https://github.com/apache/spark/pull/35362#issuecomment-1029577304
Thanks for the contribution! Given the code change is critical to the fixed time window calculation, could you please fill out the details on math in the PR description, in the section `What changes were proposed in this pull request?` ? It would be great if you can provide some calculation examples as well, tumble window / sliding window with start time. Since the existing logic works for years, we need to be very confident on changing the logic even the new logic is considered as the better one. (We often struggle about regression, especially correctness issue.) Thanks for understanding. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
