HeartSaVioR commented on a change in pull request #35343:
URL: https://github.com/apache/spark/pull/35343#discussion_r799125786
##########
File path: core/src/main/scala/org/apache/spark/util/Clock.scala
##########
@@ -99,3 +101,29 @@ private[spark] class SystemClock extends Clock {
-1
}
}
+
+/**
Review comment:
Yes. Unless the package private issue exists, I don't see the reason to
have this here. Let's roll this back to Kafka module.
The main reason I want to "isolate" the singleton and the backed class
(against public exposure) is, once we expose this as utility class, "other
tests" in "other modules" can co-use this class, which is unexpected. We will
need to narrow the scope as small as possible to avoid any side-effect.
(I know we only expose get and advance so it's hard to break unless
concurrent run of test/suites, but just a sort of defensive programming.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
