HeartSaVioR commented on a change in pull request #32875:
URL: https://github.com/apache/spark/pull/32875#discussion_r799170868
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/physical/partitioning.scala
##########
@@ -87,31 +89,6 @@ case class ClusteredDistribution(
}
}
-/**
- * Represents data where tuples have been clustered according to the hash of
the given
- * `expressions`. The hash function is defined as
`HashPartitioning.partitionIdExpression`, so only
Review comment:
I realized we even documented the characteristic I mentioned.
That said, I'd slightly in favor of be very clear about specialization of
HashClusteredDistribution & HashPartitioning on Spark internal, via prefix on
naming. The name seems to be too general and no one would know about the
characteristic unless reading through the classdoc carefully. And it would be
very confusing when someone finds a needs to have "general"
HashClusteredDistribution & HashPartitioning and somehow finds these classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
