venkata91 commented on a change in pull request #34122:
URL: https://github.com/apache/spark/pull/34122#discussion_r799178501
##########
File path:
core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala
##########
@@ -3671,7 +3671,7 @@ class DAGSchedulerSuite extends SparkFunSuite with
TempLocalSparkContext with Ti
completeShuffleMapStageSuccessfully(0, 0, parts)
val shuffleStage =
scheduler.stageIdToStage(0).asInstanceOf[ShuffleMapStage]
- assert(!shuffleStage.shuffleDep.shuffleMergeEnabled)
+ assert(shuffleStage.shuffleDep.mergerLocs.isEmpty)
Review comment:
I think here the `shuffleMergeAllowed` won't be false. Here the mergers
are not set due to not enough mergers, so it doesn't take push based shuffle
path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
