Github user aarondav commented on the pull request:

    https://github.com/apache/spark/pull/730#issuecomment-42777777
  
    I'm actually a little nervous about the default value of DEPLOY_MODE. Do 
you think we could put an explicit line in the shell script like
    
    ```
    # Default deploy mode is "client".
    DEPLOY_MODE=${DEPLOY_MODE:-"client"}
    ```
    
    We can keep the rest of your solution as-is, I just like having a 2-valued 
DEPLOY_MODE better than a 3-valued one.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to