gengliangwang commented on a change in pull request #35379:
URL: https://github.com/apache/spark/pull/35379#discussion_r800299739
##########
File path:
external/avro/src/main/scala/org/apache/spark/sql/avro/AvroSerializer.scala
##########
@@ -49,47 +54,54 @@ private[sql] class AvroSerializer(
rootAvroType: Schema,
nullable: Boolean,
positionalFieldMatch: Boolean,
- datetimeRebaseMode: LegacyBehaviorPolicy.Value) extends Logging {
+ datetimeRebaseMode: LegacyBehaviorPolicy.Value)
+ extends Logging {
def this(rootCatalystType: DataType, rootAvroType: Schema, nullable:
Boolean) = {
- this(rootCatalystType, rootAvroType, nullable, positionalFieldMatch =
false,
+ this(
+ rootCatalystType,
+ rootAvroType,
+ nullable,
+ positionalFieldMatch = false,
LegacyBehaviorPolicy.withName(SQLConf.get.getConf(SQLConf.AVRO_REBASE_MODE_IN_WRITE)))
}
def serialize(catalystData: Any): Any = {
converter.apply(catalystData)
}
- private val dateRebaseFunc = DataSourceUtils.createDateRebaseFuncInWrite(
- datetimeRebaseMode, "Avro")
+ private val dateRebaseFunc =
+ DataSourceUtils.createDateRebaseFuncInWrite(datetimeRebaseMode, "Avro")
- private val timestampRebaseFunc =
DataSourceUtils.createTimestampRebaseFuncInWrite(
- datetimeRebaseMode, "Avro")
+ private val timestampRebaseFunc =
+ DataSourceUtils.createTimestampRebaseFuncInWrite(datetimeRebaseMode,
"Avro")
private val converter: Any => Any = {
val actualAvroType = resolveNullableType(rootAvroType, nullable)
- val baseConverter = try {
- rootCatalystType match {
- case st: StructType =>
- newStructConverter(st, actualAvroType, Nil, Nil).asInstanceOf[Any =>
Any]
- case _ =>
- val tmpRow = new SpecificInternalRow(Seq(rootCatalystType))
- val converter = newConverter(rootCatalystType, actualAvroType, Nil,
Nil)
- (data: Any) =>
- tmpRow.update(0, data)
- converter.apply(tmpRow, 0)
- }
- } catch {
- case ise: IncompatibleSchemaException => throw new
IncompatibleSchemaException(
- s"Cannot convert SQL type ${rootCatalystType.sql} to Avro type
$rootAvroType.", ise)
- }
- if (nullable) {
- (data: Any) =>
- if (data == null) {
- null
- } else {
- baseConverter.apply(data)
+ val baseConverter =
Review comment:
unnecessary code change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
