zero323 commented on a change in pull request #32431:
URL: https://github.com/apache/spark/pull/32431#discussion_r800524768



##########
File path: python/pyspark/sql/dataframe.py
##########
@@ -2911,6 +2911,37 @@ def freqItems(
             support = 0.01
         return DataFrame(self._jdf.stat().freqItems(_to_seq(self._sc, cols), 
support), self.sql_ctx)
 
+    def withColumns(self, colsMap: Dict[str, Column]) -> "DataFrame":

Review comment:
       We can switch to `*colsMap` now (in the future we can switch to 
positional only)
   
   ```python
   def withColumns(self, *colsMap: Dict[str, Column]) -> "DataFrame":
       assert len(colsMap) == 1
       ...
   ```
   
   to cleanly enable `**kwargs` in the future, if there is enough support for 
such feature.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to