cloud-fan commented on a change in pull request #35355:
URL: https://github.com/apache/spark/pull/35355#discussion_r800739528
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
##########
@@ -979,8 +979,23 @@ object JdbcUtils extends Logging with SQLConfHelper {
namespace: String,
comment: String): Unit = {
val dialect = JdbcDialects.get(options.url)
+ val schemaCommentQuery = if (comment.isEmpty) {
+ comment
+ } else {
+ dialect.getSchemaCommentQuery(namespace, comment)
+ }
executeStatement(conn, options, s"CREATE SCHEMA
${dialect.quoteIdentifier(namespace)}")
- if (!comment.isEmpty) createNamespaceComment(conn, options, namespace,
comment)
+ if (comment.nonEmpty) executeStatement(conn, options, schemaCommentQuery)
Review comment:
+1 to @huaxingao 's suggestion, which is a pure code-style comment and
not related to the business logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
