bersprockets commented on a change in pull request #35430:
URL: https://github.com/apache/spark/pull/35430#discussion_r801168017
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/udaf.scala
##########
@@ -187,7 +187,7 @@ sealed trait BufferSetterGetterUtils {
row.setNullAt(ordinal)
}
- case TimestampType =>
+ case TimestampType | TimestampNTZType =>
Review comment:
This change is unrelated to the bug. However, once I added
`TimestampNTZType` to `UnsafeRow.mutableFieldTypes`, the several UDAF-related
unit tests in `HashAggregationQuerySuite` pick up this data type and try to
test it. However, BufferSetterGetterUtils could not handle this data type (and
actually, now that I look, I made the change only for the setter, not the
getter).
Alternatively, I could filter out TimestampNTZType in the two
HashAggregationQuerySuite unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
