viirya commented on a change in pull request #35426:
URL: https://github.com/apache/spark/pull/35426#discussion_r801365062
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/higherOrderFunctions.scala
##########
@@ -388,18 +388,13 @@ case class ArraySort(
checkArgumentDataTypes() match {
case TypeCheckResult.TypeCheckSuccess =>
argument.dataType match {
- case ArrayType(dt, _) if RowOrdering.isOrderable(dt) =>
Review comment:
Doesn't the above cast fail because there is `LessThan` used in the
default comparator? @HyukjinKwon's case provides a lambda function. As you
remove the check, the lambda will be executed to compare the maps.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
