HeartSaVioR commented on a change in pull request #35362:
URL: https://github.com/apache/spark/pull/35362#discussion_r801389781
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -3843,8 +3843,8 @@ object TimeWindowing extends Rule[LogicalPlan] {
* The windows are calculated as below:
* maxNumOverlapping <- ceil(windowDuration / slideDuration)
* for (i <- 0 until maxNumOverlapping)
- * windowId <- ceil((timestamp - startTime) / slideDuration)
- * windowStart <- windowId * slideDuration + (i - maxNumOverlapping) *
slideDuration + startTime
+ * lastStart <- timestamp - (timestamp - startTime + windowDuration) %
windowDuration
Review comment:
The code comment is not fixed; please don't resolve the conversation
manually. You can fix it, push the commit and the comment thread will become
outdated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
