cloud-fan commented on a change in pull request #35248:
URL: https://github.com/apache/spark/pull/35248#discussion_r801717547
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
##########
@@ -707,20 +708,30 @@ object DataSourceStrategy
agg.aggregateFunction match {
case aggregate.Min(PushableColumnWithoutNestedColumn(name)) =>
Some(new Min(FieldReference.column(name)))
+ case aggregate.Min(PushableExpression(expr)) =>
Review comment:
To simplify the code, can we make `PushableExpression` handle field
reference as well? e.g. it returns `FieldReference` if possible, or return
`GeneralSQLExpression`. Then here we can just use whatever v2 expression
returned by `PushableExpression`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
