dongjoon-hyun commented on a change in pull request #35358:
URL: https://github.com/apache/spark/pull/35358#discussion_r802159574
##########
File path:
core/src/main/scala/org/apache/spark/storage/BlockManagerDecommissioner.scala
##########
@@ -131,7 +135,10 @@ private[storage] class BlockManagerDecommissioner(
// driver a no longer referenced RDD with shuffle files.
if
(bm.migratableResolver.getMigrationBlocks(shuffleBlockInfo).size < blocks.size)
{
logWarning(s"Skipping block $shuffleBlockInfo, block
deleted.")
- } else if (fallbackStorage.isDefined) {
+ } else if (fallbackStorage.isDefined
+ // Confirm peer is not the fallback BM ID because then
fallbackStorage would
+ // already have been used in the try-block above and there's
no point trying again
+ && peer != FallbackStorage.FALLBACK_BLOCK_MANAGER_ID) {
Review comment:
Ya, I know that is a common mistake and we are mixing them frequently.
@xkrogen .
We fallback to [Java
convention](https://www.oracle.com/java/technologies/javase/codeconventions-indentation.html#248)
if there is no rule in Scala style.
Your style falls into `//DON'T USE THIS INDENTATION` example exactly in Java
convention. In short, Line 141 should not have the same indentation of line 140
for readability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
