shardulm94 commented on a change in pull request #35446:
URL: https://github.com/apache/spark/pull/35446#discussion_r802166505
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Canonicalize.scala
##########
@@ -42,7 +42,7 @@ object Canonicalize {
/** Remove names and nullability from types, and names from
`GetStructField`. */
private[expressions] def ignoreNamesTypes(e: Expression): Expression = e
match {
case a: AttributeReference =>
- AttributeReference("none", a.dataType.asNullable)(exprId = a.exprId)
+ AttributeReference("none", a.dataType)(exprId = a.exprId)
Review comment:
Good catch! The canonicalization code has change substantiantially
between 3.2 and master due to https://github.com/apache/spark/pull/34883. This
comment no longer exists in the master branch so it should not be an issue. I
will fix it in 3.2 and 3.1 PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
