HyukjinKwon commented on a change in pull request #33559:
URL: https://github.com/apache/spark/pull/33559#discussion_r802181335
##########
File path:
sql/core/src/test/resources/sql-tests/inputs/udf/postgreSQL/udf-aggregates_part3.sql
##########
@@ -247,7 +247,8 @@ select udf(max(min(unique1))) from tenk1;
-- from (values ('a', 'b')) AS v(foo,bar);
-- outer reference in FILTER (PostgreSQL extension)
-select udf((select udf(count(*))
+-- modified to remove internal udf
+select udf((select count(*)
Review comment:
Hm, @LucaCanali I think we should ideally make the existing case working
instead of avoiding it in the test. Can we try to make the matrix lazy val, and
assign it to the local variable, and use it in `rdd.mapPartitions` block at
`doExecite`?
##########
File path:
sql/core/src/test/resources/sql-tests/inputs/udf/postgreSQL/udf-aggregates_part3.sql
##########
@@ -247,7 +247,8 @@ select udf(max(min(unique1))) from tenk1;
-- from (values ('a', 'b')) AS v(foo,bar);
-- outer reference in FILTER (PostgreSQL extension)
-select udf((select udf(count(*))
+-- modified to remove internal udf
+select udf((select count(*)
Review comment:
Hm, @LucaCanali I think we should ideally make the existing case working
instead of avoiding it in the test. Can we try to make the matrix lazy val, and
assign it to the local variable, and use it in `rdd.mapPartitions` block at
`doExecute`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
