amaliujia commented on a change in pull request #35451:
URL: https://github.com/apache/spark/pull/35451#discussion_r802243525
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/dynamicpruning/PartitionPruning.scala
##########
@@ -229,6 +229,24 @@ object PartitionPruning extends Rule[LogicalPlan] with
PredicateHelper {
!plan.isStreaming && hasSelectivePredicate(plan)
}
+ /**
+ * Check the partition has static filter. So we can skip add dynamic
partition pruning
+ * if there already exists.
+ */
+ private def hasNoStaticPartitionEqualityCondition(e: Expression, p:
LogicalPlan): Boolean = {
Review comment:
Nit: use `hasStaticPartitionEqualityCondition` and reverses return
values. It might be more readable to use `has` than `not had`. When calling
this function, it will be more natural to write
`if(hasStaticPartitionEqualityCondition)` and
`if(!hasStaticPartitionEqualityCondition)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
