LuciferYang commented on pull request #35412: URL: https://github.com/apache/spark/pull/35412#issuecomment-1033404678
> I would just pass types into castingCauseOverflowError() and invoke catalogString inside of the method. Don't see any reasons to call catalogString every time. [c36aa59](https://github.com/apache/spark/pull/35412/commits/c36aa59063f89a8fb24f3fa3168b423234786472) fix this. But codegen related code in `Cast.scala` needs the original method, for example: https://github.com/apache/spark/blob/8a559b317f60e2630717a01424a7663e451fb3ce/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala#L1639-L1657 I didn't find how to call the new method in this code, so I kept the original method @MaxGekk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
