HyukjinKwon commented on a change in pull request #35410:
URL: https://github.com/apache/spark/pull/35410#discussion_r802524328
##########
File path: python/pyspark/sql/tests/test_session.py
##########
@@ -224,28 +224,26 @@ def tearDown(self):
def test_sqlcontext_with_stopped_sparksession(self):
# SPARK-30856: test that SQLContext.getOrCreate() returns a usable
instance after
# the SparkSession is restarted.
- sql_context = self.spark._wrapped
+ sql_context = SQLContext.getOrCreate(self.spark.sparkContext)
self.spark.stop()
- sc = SparkContext("local[4]", self.sc.appName)
- spark = SparkSession(sc) # Instantiate the underlying SQLContext
- new_sql_context = spark._wrapped
+ spark =
SparkSession.builder.master("local[4]").appName(self.sc.appName).getOrCreate()
+ new_sql_context = SQLContext.getOrCreate(spark.sparkContext)
self.assertIsNot(new_sql_context, sql_context)
- self.assertIs(SQLContext.getOrCreate(sc).sparkSession, spark)
+ self.assertIs(SQLContext.getOrCreate(spark.sparkContext).sparkSession,
spark)
try:
df = spark.createDataFrame([(1, 2)], ["c", "c"])
df.collect()
finally:
spark.stop()
self.assertIsNone(SQLContext._instantiatedContext)
- sc.stop()
Review comment:
`spark.stop()` calls `sc.stop()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
