amaliujia commented on pull request #34868: URL: https://github.com/apache/spark/pull/34868#issuecomment-1034479480
@beliefer can you refer to https://issues.apache.org/jira/browse/SPARK-38063 as an example to update the function specification. Basically instead of reading code, let's first document and discuss what the functions should be, especially on their argument type, input range, illegal/legal inputs, etc. After we catch edges cases by walking through the specification, writing code and code review will also be easier. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
