cloud-fan commented on a change in pull request #35459:
URL: https://github.com/apache/spark/pull/35459#discussion_r803296857
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala
##########
@@ -366,9 +364,8 @@ case class FileSourceScanExec(
@transient
private lazy val pushedDownFilters = {
val supportNestedPredicatePushdown =
DataSourceUtils.supportNestedPredicatePushdown(relation)
- // TODO: should be able to push filters containing metadata columns down
to skip files
dataFilters.filterNot(_.references.exists {
Review comment:
I think it's better to remove the metadata col filter in
`FileSourceStrategy`, as that's where we make the metadata col filter invalid:
we remove the struct-type metadata col and convert its fields to attributes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
