Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/6090#discussion_r30218458
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/sources/commands.scala ---
@@ -283,7 +283,19 @@ private[sql] abstract class BaseWriterContainer(
}
private def newOutputCommitter(context: TaskAttemptContext):
FileOutputCommitter = {
--- End diff --
I used `FileOutputCommitter` here because we need to retrieve the actual
path of file being written, which is returned by
`FileOutputCommitter.getWorkPath`. This implies customized output committers
must be subclasses of `FileOutputCommitter`, which was true for
`DirectParquetOutputCommitter`. But this restriction seems too strict.
Resorting to `OutputCommitter` rather than `FileOutputCommitter` in another PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
