allisonwang-db commented on pull request #35472: URL: https://github.com/apache/spark/pull/35472#issuecomment-1035316678
> @amaliujia We will have one new jobs for ANSI mode on. So, I think we need to read the conf value of ANSI mode and run different checks, instead of running both scenarios in one test case. @gengliangwang I think a unit test should test both ANSI on and ANSI off behaviors regardless of whether we have a new CI job or not, unless the unit test is testing against a particular ANSI behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
