HyukjinKwon commented on a change in pull request #35415:
URL: https://github.com/apache/spark/pull/35415#discussion_r804360028



##########
File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
##########
@@ -2538,6 +2538,78 @@ case class Encode(value: Expression, charset: Expression)
     newLeft: Expression, newRight: Expression): Encode = copy(value = newLeft, 
charset = newRight)
 }
 
+/**
+ * Converts the input expression to a binary value based on the supplied 
format.
+ */
+// scalastyle:off line.size.limit
+@ExpressionDescription(
+  usage = """
+            |_FUNC_(str[, fmt]) - Converts the input `str` to a binary value 
based on the supplied `fmt`.
+            |  `fmt` can be a case-insensitive string literal of "hex", 
"utf-8", "base2", or "base64".
+            |  By default, the binary format for conversion is "hex" if `fmt` 
is omitted.
+            |
+            |The function returns NULL if at least one of the input parameters 
is NULL.
+          """,

Review comment:
       I think we shouldn't use `|`s here. Should be something like:
   
   ```
     usage = """
       _FUNC_(expr[, relativeSD]) - Returns the estimated cardinality by 
HyperLogLog++.
         `relativeSD` defines the maximum relative standard deviation 
allowed.""",
   ```
   
   (see the docs of `ExpressionDescription`)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to