Yikun commented on a change in pull request #35422:
URL: https://github.com/apache/spark/pull/35422#discussion_r804558321
##########
File path: resource-managers/kubernetes/core/pom.xml
##########
@@ -29,8 +29,25 @@
<name>Spark Project Kubernetes</name>
<properties>
<sbt.project.name>kubernetes</sbt.project.name>
+ <volcano.exclude>**/*Volcano*.scala</volcano.exclude>
</properties>
+ <profiles>
+ <profile>
+ <id>volcano</id>
Review comment:
Yep, we had some discussion on:
https://github.com/apache/spark/pull/35422#discussion_r800986656, as dongjoon
suggestion:
```
Technically, Apache Spark uses three options when it embraces new features.
I'd prefer (2). Shall we put this under -Pvolcano profile please?
1. External module like Kafka Streaming
2. Profile like HiveThriftServer or SparkR
3. Built-in module.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
