dongjoon-hyun commented on a change in pull request #35477:
URL: https://github.com/apache/spark/pull/35477#discussion_r804936754
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/FileStreamOptions.scala
##########
@@ -33,9 +33,9 @@ class FileStreamOptions(parameters:
CaseInsensitiveMap[String]) extends Logging
def this(parameters: Map[String, String]) =
this(CaseInsensitiveMap(parameters))
- checkDisallowedOptions(parameters)
+ checkDisallowedOptions()
- private def checkDisallowedOptions(options: Map[String, String]): Unit = {
+ private def checkDisallowedOptions(): Unit = {
Seq(ModifiedBeforeFilter.PARAM_NAME,
ModifiedAfterFilter.PARAM_NAME).foreach { param =>
if (parameters.contains(param)) {
Review comment:
It seems that the original design wanted to use `options` here. However,
`CaseInsensitiveMap` and `Map` is different. So, I agree with this new change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
