xkrogen commented on a change in pull request #35494:
URL: https://github.com/apache/spark/pull/35494#discussion_r807233625
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
##########
@@ -41,7 +41,7 @@ import
org.apache.spark.sql.catalyst.streaming.StreamingRelationV2
import org.apache.spark.sql.catalyst.util.ExpressionSQLBuilder
import org.apache.spark.sql.connector.catalog.SupportsRead
import org.apache.spark.sql.connector.catalog.TableCapability._
-import org.apache.spark.sql.connector.expressions.{Expression => ExpressionV2,
FieldReference, GeneralSQLExpression, NullOrdering, SortDirection, SortOrder =>
SortOrderV2, SortValue}
+import org.apache.spark.sql.connector.expressions.{Expression => V2Expression,
FieldReference, NullOrdering, SortDirection, SortOrder => V2SortOrder,
SortValue}
Review comment:
Why do we rename `ExpressionV2` to `V2Expression` (same for
`SortOrder`)? IMO the old format is much easier to read and aligns more closely
with other naming conventions like "DataSource V2"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
