HeartSaVioR commented on a change in pull request #35526:
URL: https://github.com/apache/spark/pull/35526#discussion_r807402650
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameTimeWindowingSuite.scala
##########
@@ -490,4 +490,46 @@ class DataFrameTimeWindowingSuite extends QueryTest with
SharedSparkSession {
assert(attributeReference.dataType == tuple._2)
}
}
+
+ test("SPARK-38214: No need to filter data when the sliding window length is
not redundant") {
Review comment:
It would be nice if we are clear about what we want to test.
If we want to verify that the change still produces right windows, I'd
rather verify the boundary of time range explicitly instead of just checking
the value column, even it is much verbose. The test would be general one so
doesn't need to have JIRA ticket number and the name of the test should be also
general.
If we have such test in existing tests, and want to ensure we don't inject
comparison expression on calculation of time window, we probably need to look
into logical plan (especially Filter) and verify the expression used in Filter.
If we have such test in existing tests and you feel uneasy to verify the
expression in Filter node, it's OK to skip adding the test, since it means the
functionality is validated with existing tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
