Yikun commented on a change in pull request #35499:
URL: https://github.com/apache/spark/pull/35499#discussion_r807414222
##########
File path:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesConf.scala
##########
@@ -195,7 +197,9 @@ private[spark] class KubernetesExecutorConf(
KubernetesVolumeUtils.parseVolumesWithPrefix(sparkConf,
KUBERNETES_EXECUTOR_VOLUMES_PREFIX)
}
- override def schedulerName: String =
get(KUBERNETES_EXECUTOR_SCHEDULER_NAME).getOrElse("")
+ override def schedulerName: String = {
+
get(KUBERNETES_EXECUTOR_SCHEDULER_NAME).getOrElse(get(KUBERNETES_SCHEDULER_NAME).getOrElse(""))
Review comment:
there are some unexpected behaviours in my integration test, I only set
new scheduler name config, but when get(KUBERNETES_EXECUTOR_SCHEDULER) return
"" rather null.
So it does't work as expected. Will address today
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
