LeeeeLiu commented on pull request #35513: URL: https://github.com/apache/spark/pull/35513#issuecomment-1041034503
> Assuming you've verified this fix manually, could you please produce the step to reproduce, and the exact log message you got? It would be nice if we have it in the section of "How was this patch tested?". > > Your new test doesn't test the new change (although it's hard to test against log message), so the manual verification seems to be required. Hi @HeartSaVioR , I will give detailed test instructions in the section of "How was this patch tested?". I actually tested the original exception in the new test. Because I don't know how to test for error messages. However, when an exception is thrown, a newly added error message is printed. So I think this new test tests a new change. I have manually compiled the master branch to simulate, and the error messages will also output normally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
