HeartSaVioR edited a comment on pull request #34089: URL: https://github.com/apache/spark/pull/34089#issuecomment-1039543790
@ijuma Thanks for the update. Much appreciated on your active feedbacks. ~~Btw, I see the mentioning is about a bug on new default value of idempotent not properly accounted. It doesn't mention about performance implication of changing default value of ack/idempotent. (That is still not mentioned.)~~ ~~If that is the Kafka community's call to consider it as minor/trivial then I'll rely on that (since we will transparently route the issue to Kafka community), but I'd wonder the reason the action is taken opposite way with the conclusion of analysis. If that is just a missing spot, it would be really helpful if Kafka community addresses it.~~ EDIT: I had to look "above" the line. My bad. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
