cloud-fan commented on a change in pull request #35511:
URL: https://github.com/apache/spark/pull/35511#discussion_r807529783
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLInsertTestSuite.scala
##########
@@ -286,20 +286,28 @@ trait SQLInsertTestSuite extends QueryTest with
SQLTestUtils {
} else {
SQLConf.StoreAssignmentPolicy.values
}
+
+ def shouldThrowException(policy: SQLConf.StoreAssignmentPolicy.Value):
Boolean = policy match {
+ case SQLConf.StoreAssignmentPolicy.ANSI |
SQLConf.StoreAssignmentPolicy.STRICT =>
+ true
+ case SQLConf.StoreAssignmentPolicy.LEGACY =>
+ SQLConf.get.ansiEnabled
Review comment:
Why don't we change the current code? I believe it's a mistake that we
don't forbid it. We forbid users to turn off ansi mode with ansi store
assignment, isn't it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
