dongjoon-hyun commented on a change in pull request #35404:
URL: https://github.com/apache/spark/pull/35404#discussion_r808744374
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
##########
@@ -4294,6 +4294,31 @@ class SQLQuerySuite extends QueryTest with
SharedSparkSession with AdaptiveSpark
Row(3, 2, 6) :: Nil)
}
}
+
+ test("SPARK-38118: Func(wrong_type) in the HAVING clause should throw data
mismatch error") {
Review comment:
Thank you for adding this. Do you think you can add a test coverage in
`catalyst` module too because your main contribution is inside `catalyst`
module.
We recommend to keep the patch main code and test code in **the same module
closely** in order to maintain the modules more completely by themselves and to
test them more easily.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
