somani commented on a change in pull request #35527:
URL: https://github.com/apache/spark/pull/35527#discussion_r808909380
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/rules.scala
##########
@@ -319,15 +319,7 @@ case class PreprocessTableCreation(sparkSession:
SparkSession) extends Rule[Logi
conf.resolver)
if (schema.nonEmpty && normalizedPartitionCols.length == schema.length) {
- if (DDLUtils.isHiveTable(table)) {
Review comment:
Sorry just got to this.
> If Hive allows cols to inherit partitioned columns, we should not do
partition in toHiveTable, if not, we should fail early, I'm sorry I'm not sure
about that
... what do we mean by "cols to inherit partitioned columns"?
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/rules.scala
##########
@@ -319,15 +319,7 @@ case class PreprocessTableCreation(sparkSession:
SparkSession) extends Rule[Logi
conf.resolver)
if (schema.nonEmpty && normalizedPartitionCols.length == schema.length) {
- if (DDLUtils.isHiveTable(table)) {
Review comment:
Sorry just got to this.
> If Hive allows cols to inherit partitioned columns, we should not do
partition in toHiveTable, if not, we should fail early, I'm sorry I'm not sure
about that
... what do we mean by "cols to inherit partitioned columns"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
