zero323 commented on a change in pull request #35554:
URL: https://github.com/apache/spark/pull/35554#discussion_r809276588
##########
File path: python/pyspark/mllib/classification.py
##########
@@ -278,7 +278,10 @@ def load(cls, sc, path):
return model
def __repr__(self):
Review comment:
Strictly speaking, this should be `__str__` not `__repr__`, unless we
want to match constructor not JVM counterpart. Shall we change it? Diverge in
ouput?
##########
File path: python/pyspark/mllib/classification.py
##########
@@ -278,7 +278,10 @@ def load(cls, sc, path):
return model
def __repr__(self):
Review comment:
Strictly speaking, this should be `__str__` not `__repr__`, unless we
want to match constructor not JVM counterpart. Shall we change it? Diverge in
output?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
